Open
Conversation
This refactors the code base to get rid of lodash.get, which has been deprecated in favor of the `?.` operator. Since this project promises support with node >= 8.12 (see package.json:16) and `?.` is in Node.js since v14 I do not use it in these changes. Rather, I use old school JavaScript to achieve the same effect as these two alternatives. In most cases where `lodash.get` was being used it was pretty much useless and thus would not even require `?.`. In some cases it side-stepped the type checker and the refactored code adds the appropriate type checks.
This was referenced Jan 25, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the code base to get rid of
lodash.get, which has been deprecated in favor of the?.operator. Since this project promises support with node >= 8.12 and?.is in Node.js since v14 I do not use it in these changes. Rather, I use old school JavaScript to achieve the same effect as these two alternatives. In most cases wherelodash.getwas being used it was pretty much useless and thus would not even require?., instead maybe providing an alternative for a default value. In some other cases its use side-stepped the type checker and the refactored code adds the appropriate type checks.